BorlandTalk.com

Boefje · Guest

Hi,

I am using a Oracle database. Now I want to do a fairly simpel update.

The code is like this:

try
ADOQueryUpdate.Close;
ADOQueryUpdate.SQL.Text := 'UPDATE contracts SET ';
ADOQueryUpdate.SQL.Add(' contract_id = '+IntToStr(pId);
ADOQueryUpdate.SQL.Add(' WHERE account_id = '+
IntToStr(pAccountId));
ADOQueryUpdate.ExecSQL;
except
on e: exception do
ShowMessage('Error: Data could not be written!');
end;

If I do this my application does not continue. I think the reason is
simple, it has to commit the executed statement. But how?

This does not work:

ADOQueryUpdate.SQL.Text := 'UPDATE contracts SET ';
ADOQueryUpdate.SQL.Add(' contract_id = '+IntToStr(pId);
ADOQueryUpdate.SQL.Add(' WHERE account_id = '+
IntToStr(pAccountId)+';');
ADOQueryUpdate.SQL.Add(' 'COMMIT;');
ADOQueryUpdate.ExecSQL;

It says: "ORA-00911: invalid character"

So it does not except the ';'. So what should I do?

By the way I am using Delphi 5 and two ADO components, just
TADOConnection and TADOQuery (so no TDatabase component)

Thanks

Ryan · Guest

Should this ...

ADOQueryUpdate.SQL.Add(' contract_id = '+IntToStr(pId);

Be ???

ADOQueryUpdate.SQL.Add(' contract_id = ')+IntToStr(pId);

Looks like you are missing a bracket.

Ryan

Boefje wrote:

Ryan · Guest

Should this ...

ADOQueryUpdate.SQL.Add(' contract_id = '+IntToStr(pId);

Be ???

ADOQueryUpdate.SQL.Add(' contract_id = ')+IntToStr(pId);

Looks like you are missing a bracket.

Ryan

Boefje wrote:

DEHilliard · Guest

I use Delphi 7 with Oracle and ADO, one of the things I find extremely
valuable in debugging SQL, is the: SQL.SaveToFile( filename ) ;

I can then run the SQL that Oracle sees in SQL Plus.

Since you have your SQL in a Try, Except Structure
try using the ADOConnection.BeginTrans
and ADOConnection.CommitTrans
and ADOConnection.RollBackTrans.