BorlandTalk.com

Ramy · Guest

Hi, i think it's better to open new tread becouse the last one
already has too many subjects. My new code is the code bellow,
my button base on a Panel, on this panel i have a small image
which is part of the button's class ( later i'll add also
2 labels under this image ), when i move the mouse curser over
the button i show the panel Inner Bevel, when the mouse is out
of the button i don't show this bevel ( BevelInner = bvNone ).

As i said in the other tread i also need to know if the user
has press inside the button but released the mouse button only
when it was out of my button's borders, then i don't want to
call my ButtonClick operation.

I see 2 problems with this code -

1. if i enter to the button slow and inside the image, and then
go out of the button slowly then everything is fine. but if i am
inside the image, and then i move the mouse fast ( not even too
fast ) out of the button's borders, then the WndProc get only
'CM_MOUSELEAVE' message for the Image, but is doesn't get the
'CM_MOUSELEAVE' and the 'CM_MOUSEENTER' messages for the panel,
so the application still think that it is inside the button
( and i still see panel's bevel... ). Why? and how can i solve
such situations?

2. If i click inside the button, on the image for example, and
then i move the mouse cursor out of the button, and only then
release it, the application still think that it is inside the
button and it calls the MouseUpInsideButton(); function,
this is not good, if the user released the mouse button out
of the button i don't want to do the operation.

Is there any good solution for this situation?

Thanks very much,
Ramy

Here is the code -

// - - - - - - - - - - - WndProc - - - - - - - - - - - - -

void __fastcall TBaseButton::WndProc( TMessage &Message )
{
static bool MouseAlreadyInButton = false;

if ( Message.Msg == CM_MOUSEENTER || Message.Msg == CM_MOUSELEAVE )
{
TImage *ImagePtr = dynamic_cast<TImage*>( reinterpret_cast<TControl*>( Message.LParam ) );

if ( Message.Msg == CM_MOUSEENTER )
{
if ( ImagePtr )
MouseAlreadyInButton = true;
else
if( !MouseAlreadyInButton )
OnMouseEnter();
}
else if( !ImagePtr )
{
RECT Rect;
POINT Point;
::GetWindowRect( Handle, &Rect ); // ( Win 32 Call )
::GetCursorPos( &Point ); // ( Win 32 Call )

if ( !::PtInRect( &Rect, Point ) )
{
MouseAlreadyInButton = false;
OnMouseLeave();
}
}
}

if ( MouseInImage )
{
if ( Message.Msg == WM_LBUTTONDOWN )
{
MouseDownInsideButton();
}

if ( Message.Msg == WM_LBUTTONUP )
{
MouseUpInsideButton(); // = "Button Click"
}
}

inherited::WndProc( Message );
}

// Mouse Enter Event

// - - - - - - - - - - Mouse Enter - - - - - - - - - - - - -

void __fastcall TBaseButton::OnMouseEnter( void )
{
BevelOuter = bvNone;
BevelInner = bvRaised;
MouseInImage = true;
}

// - - - - - - - - - - Mouse Leave - - - - - - - - - - - - -

// Mouse Leave Event

void __fastcall TBaseButton::OnMouseLeave( void )
{
BevelOuter = bvNone;
BevelInner = bvNone;
MouseInImage = false;
}

Ramy · Guest

OK forget for now about problem 2, i solved it like this -

if ( MouseInImage )
{
if ( Message.Msg == WM_LBUTTONDOWN )
{
MouseDownInsideButton();
}

if ( Message.Msg == WM_LBUTTONUP )
{
RECT Rect;
POINT Point;
::GetWindowRect( Handle, &Rect ); // ( Win 32 Call )
::GetCursorPos( &Point ); // ( Win 32 Call )

if ( !::PtInRect( &Rect, Point ) )
{
MouseAlreadyInButton = false;
OnMouseLeave();
}
else
MouseUpInsideButton(); // = "Button Click"
}
}

Although that it's not a perfect solution becouse i want the
panel's bevel to disappear at the moment i leave the button's
borders, but in my solution if the user press inside the button
and release the mouse left button only when it's out of the
button, then the panel's bevel will be visible untill the user
has release the mouse button...

Thanks,
Ramy

JD · Guest

"Ramy" <Ramy (AT) NoMail (DOT) com> wrote:

Ramy · Guest

Hmm... maybe i was a little confused... i think that you already
gave me the answer, i'll check it and let you know if i'll have
problem with this code, now after that i removed the Bevel.

"If the only reason that you're keeping track of the mouse
entering and leaving the panel/image is to know when it was
clicked, you can delete all of that code and use the mouse
events directly.

Assign OnMouseDown/Move/Up events to the Image and check for
clicking only on the Image:

class TBaseButton : public TPanel
{
private:
bool Clicked;
void __fastcall ImageMouseDown(TObject *Sender, TMouseButton Button, TShiftState Shift, int X, int Y);
void __fastcall ImageMouseMove(TObject *Sender, TShiftState Shift, int X, int Y);
void __fastcall ImageMouseUp(TObject *Sender, TMouseButton Button, TShiftState Shift, int X, int Y);
};

//-------------------------------------------------------------
__fastcall TBaseButton::TBaseButton(TComponent* Owner) : TPanel( Owner )
{
Clicked = false;
// allocate the image
Image->OnMouseDown = ImageMouseDown;
Image->OnMouseMove = ImageMouseMove;
Image->OnMouseUp = ImageMouseUp;
}
//-------------------------------------------------------------
void __fastcall TBaseButton::ImageMouseDown(TObject *Sender, TMouseButton Button, TShiftState Shift, int X, int Y)
{
Clicked = true;
// call the function to animate a button down click
}
//-------------------------------------------------------------
void __fastcall TBaseButton::ImageMouseMove(TObject *Sender, TShiftState Shift, int X, int Y)
{
if( Shift.Contains(ssLeft) )
{
RECT Rect;
POINT Point;
::GetWindowRect( Image->Handle, &Rect );
::GetCursorPos( &Point );
if( ! ::PtInRect(&Rect, Point) )
{
// animate the button up
Clicked = false;
}
}
}
//-------------------------------------------------------------
void __fastcall TBaseButton::ImageMouseUp(TObject *Sender, TMouseButton Button, TShiftState Shift, int X, int Y)
{
if( Clicked )
{
Clicked = false;
// animate the button up
// perform OnClick
}
}
//-------------------------------------------------------------

~ JD"

JD · Guest

"Ramy" <Ramy (AT) NoMail (DOT) com> wrote:

Ramy · Guest

Hi JD, if you still have that test on your PC, can you please
copy - paste it's code into your next respond in this thread?

Thanks!

"JD" <nospam (AT) nospam (DOT) com> wrote:

JD · Guest

"Ramy" <Ramy (AT) NoMail (DOT) com> wrote:

Ramy · Guest

Sorry JD i did not see this post, don't have to be so angry,
i'm reading the newsgroup directly from Borland's pages and it's
very hard to follow messages here becouse you don't see them as
one cluster of messages, but messages from one thread are
scattered all around over several pages, so i missed this post.

I'll test your code, and i'll let you know how it goes, thanks.

Ramy

"JD" <nospam (AT) nospam (DOT) com> wrote:

Ramy · Guest

Hi JD!

Your new code works great! :-)

I did several changings, for example i kept getting an arror of
"control has no parent window" on the line -

hdc = ::GetDC( Handle );

which was solved after i added this line before it -

Parent = dynamic_cast<TWinControl *>( Owner );

But then i kept getting another error (don't even remember
even what) on the Destructor...

But it doesn't matter any more, i just removed all the code for
the Canvas becouse i don't really need it, i just changes the
Panel's bevels to get the effect that i need.

I'm just interesting, what did you change between this code and
the code before, that solved the problem of not detecting
"MouseLeave" when i moved the mouse fast from the image and out
of the button? becouse now it's working real good, what's the
different than?

Anyway, thanks a LOT for your help!

( My code after the changings is bellow )

Ramy

__fastcall TBaseButton::TBaseButton( TComponent *Owner ) : TPanel( Owner )
{
ButtonImage = new TImage( this );
ButtonImage->Parent = this;
ButtonImage->AutoSize = true;
ButtonImage->Stretch = true;
ButtonImage->Picture->LoadFromFile( "CloseIcon.bmp" );
ButtonImage->Top = 10;
ButtonImage->Left = 10;

ButtonImage->OnMouseDown = ButtonImageMouseDown;
ButtonImage->OnMouseMove = ButtonImageMouseMove;
ButtonImage->OnMouseUp = ButtonImageMouseUp;

ButtonImage->OnMouseDown = ButtonImageMouseDown;
ButtonImage->OnMouseMove = ButtonImageMouseMove;
ButtonImage->OnMouseUp = ButtonImageMouseUp;

BevelOuter = bvNone;
BevelInner = bvNone;
}

//-------------------------------------------------------------

__fastcall TBaseButton::~TBaseButton()
{
//
}

//-------------------------------------------------------------

void __fastcall TBaseButton::WndProc( TMessage &Message )
{
if( Message.Msg == CM_MOUSEENTER || Message.Msg == CM_MOUSELEAVE )
{
TRect r = Rect( 0, 0, Width, Height );

if ( MouseInButton() )
{
BevelOuter = bvNone;
BevelInner = bvRaised;
Form1->Label1->Caption = "In";
}
else
{
BevelOuter = bvNone;
BevelInner = bvNone;
Form1->Label1->Caption = "Out";
}
}

inherited::WndProc( Message );
}

//-------------------------------------------------------------

void __fastcall TBaseButton::MouseDown( TMouseButton Button, TShiftState Shift, int X, int Y )
{
ButtonMouseDown();
inherited::MouseDown( Button, Shift, X, Y );
}

//-------------------------------------------------------------

void __fastcall TBaseButton::MouseMove( TShiftState Shift, int X, int Y )
{
ButtonMouseMove( Shift );
inherited::MouseMove( Shift, X, Y );
}

//-------------------------------------------------------------

void __fastcall TBaseButton::MouseUp( TMouseButton Button, TShiftState Shift, int X, int Y )
{
ButtonMouseUp();
inherited::MouseUp( Button, Shift, X, Y );
}

//-------------------------------------------------------------

void __fastcall TBaseButton::ButtonImageMouseDown( TObject *Sender, TMouseButton Button, TShiftState Shift, int X, int Y )
{
ButtonMouseDown();
}

//-------------------------------------------------------------

void __fastcall TBaseButton::ButtonImageMouseMove( TObject *Sender, TShiftState Shift, int X, int Y )
{
ButtonMouseMove( Shift );
}

//-------------------------------------------------------------

void __fastcall TBaseButton::ButtonImageMouseUp( TObject *Sender, TMouseButton Button, TShiftState Shift, int X, int Y )
{
ButtonMouseUp();
}

//-------------------------------------------------------------

void __fastcall TBaseButton::ButtonMouseDown()
{
TRect r = Rect( 0, 0, Width, Height );
BevelOuter = bvRaised;
BevelInner = bvRaised;
ButtonImage->Left = ButtonImage->Left + 1;
ButtonImage->Top = ButtonImage->Top + 1;
ButtonDown = true;
}

//-------------------------------------------------------------

void __fastcall TBaseButton::ButtonMouseMove( TShiftState Shift )
{
if ( Shift.Contains(ssLeft) && ButtonDown )
{
if ( !MouseInButton() )
ReleaseButton();
}
}

//-------------------------------------------------------------

void __fastcall TBaseButton::ButtonMouseUp()
{
if( ButtonDown )
{
ReleaseButton();
ShowMessage( "Execute Button Click" );
}
}

//-------------------------------------------------------------

bool __fastcall TBaseButton::MouseInButton()
{
RECT Rect;
POINT Point;
::GetWindowRect( Handle, &Rect );
::GetCursorPos( &Point );

if( ! ::PtInRect( &Rect, Point ) )
return false;
else
return true;
}

//-------------------------------------------------------------

void __fastcall TBaseButton::ReleaseButton()
{
TRect r = Rect( 0, 0, Width, Height);
BevelOuter = bvNone;
BevelInner = bvNone;
Form1->Label1->Caption = "Out";
ButtonImage->Left = ButtonImage->Left - 1;
ButtonImage->Top = ButtonImage->Top - 1;
ButtonDown = false;
}

//-------------------------------------------------------------

void __fastcall TForm1::Timer1Timer( TObject *Sender )
{
Timer1->Enabled = false;

TBaseButton *Button1 = new TBaseButton( this );
Button1->Parent = this;
Button1->Top = 20;
Button1->Left = 20;
Button1->Width = 40;
Button1->Height = 40;
}

//--------------------------------------------------------------

Ramy · Guest

__fastcall TBaseButton::~TBaseButton()
{
delete ButtonImage;
}

Of Course....

Ramy

JD · Guest

"Ramy" <Ramy (AT) NoMail (DOT) com> wrote:

JD · Guest

"Ramy" <Ramy (AT) NoMail (DOT) com> wrote:

JD · Guest

"Ramy" <Ramy (AT) NoMail (DOT) com> wrote:

Ramy · Guest

Ramy · Guest

Thanks, basicaly i know this rule, i don't know why i did that,
but tell me, why in your example did you wrote -

[...]
ButtonCanvas = new TCanvas();
[...]

and than -

__fastcall TBaseButton::~TBaseButton()
{
delete ButtonCanvas;
[...]
}

?

Why didn't you gave the ButtonCanvas an owner so that when the
button is destroyed so is the ButtonCanvas? why did you have to
destroyed it manualy in your Destructor?

Ramy