BorlandTalk.com

Jacques · Guest

Does anyone know the equivalent of read/writebuffer in indy10? I'm just
updating a tcp chat server tht i wrote in indy 9. Here's the code:

procedure TForm1.serverExecute(AContext: TIdContext);
var
ActClient, RecClient: PClient;
CommBlock, NewCommBlock: TCommBlock;//defined in a separate unit,basically
a record of client info
RecThread: TIdcontext;
i: Integer;

begin
if not AContext.Connection.Connected and AContext.Connection.Connected
then
begin
AContext.Connection.IOHandler.Readln (CommBlock, SizeOf
(CommBlock));//this line is the problem previous i had readbuffer where
Readln is
ActClient := PClient(AContext.Data);
ActClient.LastAction := Now; // update the time of last action

if (CommBlock.Command = 'MESSAGE') or (CommBlock.Command = 'DIALOG')
then
begin // 'MESSAGE': A message was send - forward or broadcast it
// 'DIALOG': A dialog-window shall popup on the recipient's
screen
// it's the same code for both commands...

if CommBlock.ReceiverName = '' then
begin // no recipient given - broadcast
Protocol.Lines.Add (TimeToStr(Time)+' Broadcasting
'+CommBlock.Command+': "'+CommBlock.Msg+'"');
NewCommBlock := CommBlock; // nothing to change Wink

)

with Clients.LockList do
try
for i := 0 to Count-1 do // iterate through client-list
begin
RecClient := Items[i]; // get client-object
RecThread := RecClient.Thread; // get client-thread out of
it
RecThread.Connection.WriteBuffer(NewCommBlock,
SizeOf(NewCommBlock), True); // send the stuff
end;
finally
Clients.UnlockList;
end;
end
else
begin // receiver given - search him and send it to him
NewCommBlock := CommBlock; // again: nothing to change Wink

)
Protocol.Lines.Add(TimeToStr(Time)+' Sending '+CommBlock.Command+'
to "'+CommBlock.ReceiverName+'": "'+CommBlock.Msg+'"');
with Clients.LockList do
try
for i := 0 to Count-1 do
begin
RecClient:=Items[i];
if RecClient.DNS=CommBlock.ReceiverName then // we don't have a
login function so we have to use the DNS (Hostname)
begin
RecThread:=RecClient.Thread;
RecThread.Connection.WriteBuffer(NewCommBlock,
SizeOf(NewCommBlock), True);
end;
end;
finally
Clients.UnlockList;
end;
end;
end
else
begin // unknown command given
Protocol.Lines.Add (TimeToStr(Time)+' Unknown command from
"'+CommBlock.MyUserName+'": '+CommBlock.Command);
NewCommBlock.Command := 'DIALOG'; // the message should popup on
the client's screen
NewCommBlock.MyUserName := '[Server]'; // the server's username
NewCommBlock.Msg := 'I don''t understand your command:
"'+CommBlock.Command+'"'; // the message to show
NewCommBlock.ReceiverName := '[return-to-sender]'; // unnecessary

AContext.Connection.WriteBuffer (NewCommBlock, SizeOf (NewCommBlock),
true); // and there it goes...
end;
end;
end;

Error msg:[Error] chatserv.pas(56): There is no overloaded version of
'ReadLn' that can be called with these arguments
thanks

DonS · Guest

Remy Lebeau (TeamB) · Guest

"Jacques" <jacques.noah (AT) btinternet (DOT) com> wrote

Jacques · Guest

thank you both for your replies, it has been a great help. The only problem
i have is that whenever i run the program, i get an error saying that
rawtobytes/bytestoraw is undefined function. I have addded idglobal to my
uses clause, as i thought the function was defined there. Am i missing
something?

"Remy Lebeau (TeamB)" <no.spam (AT) no (DOT) spam.com> wrote

Remy Lebeau (TeamB) · Guest

"Jacques" <jacques.noah (AT) btinternet (DOT) com> wrote

Jacques · Guest

I'm compiling for Win32/D7/indy 10.0.20. I've checked in the idglobal.pas
file, and i only have rawtobytes function in that file. I dont have the
rest.

Is there someplace i can get them?

"Remy Lebeau (TeamB)" <no.spam (AT) no (DOT) spam.com> wrote

Remy Lebeau (TeamB) · Guest

"Jacques" <jacques.noah (AT) btinternet (DOT) com> wrote

Jacques · Guest

Thank you vewry much. I've now downloaded the latest indy version and it
works well. There is just one more problem. It seems to be one thing after
another with this app! It is very frustrating when you dont know what to do
next??!! Please help.

in the code below i get the following errors:

[Error] chatserv.pas(8 Cool

: Record, object or class type required
[Error] chatserv.pas(8 Cool

: Missing operator or semicolon
[Error] chatserv.pas(8 Cool

: Illegal type in Write/Writeln statement

type
PClient = ^TClient;
TClient = record // Object holding data of client (see events)
DNS : String[20]; { Hostname }
Connected, { Time of connect }
LastAction : TDateTime; { Time of last
transaction }
Thread : Pointer; { Pointer to thread }
end;

procedure TForm1.serverExecute(AContext: TIdContext);
var
ActClient, RecClient: PClient;
CommBlock, NewCommBlock: TCommBlock;
RecThread: TIdcontext;
i: Integer;
ABytes: TIdBytes;
begin
if not AContext.Connection.Connected and AContext.Connection.Connected
then
begin
SetLength(ABytes, SizeOf(CommBlock));
// AContext.Connection.IOHandler.ReadBytes(ABytes, SizeOf(CommBlock),
False);

AContext.Connection.IOHandler.ReadBytes(ABytes, SizeOf(CommBlock), False);
BytesToRaw(abytes, CommBlock, SizeOf(CommBlock));

ActClient := PClient(AContext.Data);
ActClient.LastAction := Now; // update the time of last action

if (CommBlock.Command = 'MESSAGE') or (CommBlock.Command = 'DIALOG')
then
begin // 'MESSAGE': A message was send - forward or broadcast it
// 'DIALOG': A dialog-window shall popup on the recipient's
screen
// it's the same code for both commands...

if CommBlock.ReceiverName = '' then
begin // no recipient given - broadcast
logmemo.Lines.Add (TimeToStr(Time)+' Broadcasting
'+CommBlock.Command+': "'+CommBlock.Msg+'"');
NewCommBlock := CommBlock; // nothing to change Wink

)

with Clients.LockList do
try
for i := 0 to Count-1 do // iterate through client-list
begin
RecClient := Items[i]; // get client-object
RecThread := RecClient.Thread; // get client-thread out of
it

RawToBytesf(abytes, NewCommBlock, SizeOf(NewCommBlock));

ABytes := RawToBytes(NewCommBlock, SizeOf(NewCommBlock));
pclient(items[i]).Thread.Connection.IOHandler.write(abytes);
//line 88
// RecThread.Connection.WriteBuffer(NewCommBlock, SizeOf(NewCommBlock),
True);
end;

Thanks

"Remy Lebeau (TeamB)" <no.spam (AT) no (DOT) spam.com> wrote

Remy Lebeau (TeamB) · Guest

"Jacques" <jacques.noah (AT) btinternet (DOT) com> wrote

Jacques · Guest

Thanks,i've tried to correct most of the code, but i do not understand what
you are saying here:

Remy Lebeau (TeamB) · Guest

"Jacques" <jacques.noah (AT) btinternet (DOT) com> wrote

Jacques · Guest

Everything on this chat works well, except, it does not display the msg when
it is sent by person A to person B, which is really the whole point of a
chat. On the client side the two procedures to recieve the msg are :
HandleInput and Execute(as below).

Client Code:
TClientHandleThread = class(TThread)
private
CB: TCommBlock;

procedure HandleInput;

protected
procedure Execute; override;

end;
var
Form1: TForm1;
ClientHandleThread: TClientHandleThread; // variable (type see above)
implementation

{$R *.dfm}

//this section is meant to display the msg from the server

procedure TClientHandleThread.HandleInput;
begin
if CB.Command = 'MESSAGE' then

//this memobox should be displying the incomming msg
form1.IncomingMessages.Lines.Add (CB.MyUserName + ': ' + CB.Msg)

else
if CB.Command = 'DIALOG' then
MessageDlg ('"'+CB.MyUserName+'" sends you this message:'+#13+CB.Msg,
mtInformation, [mbOk], 0)
else // unknown command
MessageDlg('Unknown command "'+CB.Command+'" containing this
message:'+#13+CB.Msg, mtError, [mbOk], 0);
end;

procedure TClientHandleThread.Execute;
var ABytes: TIdBytes;
begin
while not Terminated do
begin
if not form1.Client.Connected then
Terminate
else
try
SetLength(ABytes, SizeOf(CB));
form1.client.IOHandler.ReadBytes(ABytes, SizeOf(CB), False);

BytesToRaw(abytes, CB, SizeOf(CB));
{AContext.Connection.IOHandler.ReadBytes(ABytes, SizeOf(CommBlock),
False);
BytesToRaw(abytes, CommBlock, SizeOf(CommBlock));
}

Synchronize(HandleInput);
except
end;
end;
end;

Server code:

var
ActClient, RecClient: PClient;
CommBlock, NewCommBlock: TCommBlock;
RecThread: TIdcontext;
i: Integer;
ABytes: TIdBytes;
begin

SetLength(ABytes, SizeOf(CommBlock));
AContext.Connection.IOHandler.ReadBytes(ABytes, SizeOf(CommBlock), False);
BytesToRaw(abytes, CommBlock, SizeOf(CommBlock));

//..........

//This code sends the message:

begin // receiver name given - search him and send it to him
NewCommBlock := CommBlock;
{ logmemo.Lines.Add(TimeToStr(Time)+' Sending '+CommBlock.Command+'
to "'+CommBlock.ReceiverName+'": "'+CommBlock.Msg+'"');}
with Clients.LockList do
try
for i := 0 to Count-1 do
begin
RecClient:=Items[i];
if RecClient.DNS=CommBlock.ReceiverName then // we don't have a
login function so we have to use the DNS (Hostname)
begin
RecThread:=RecClient.Thread;
ABytes := RawToBytes(NewCommBlock, SizeOf(NewCommBlock));

RawToBytesF(ABytes, NewCommBlock, SizeOf(NewCommBlock));

//Also, should it be Acontext.Connection.IOHandler.Write(ABytes); or as
below?
RecThread.Connection.IOHandler.Write(ABytes);
end;
end;
finally
Clients.UnlockList;

Furthermore, is there a way to display a list of who logged on to the chat
to all the people that is on the chat already? I 've created a list that
takes everybody's details, when they log in. So it's probably a matter of
doing a locklist and sending it out?

Thanks

"Remy Lebeau (TeamB)" <no.spam (AT) no (DOT) spam.com> wrote