BorlandTalk.com Forum Index BorlandTalk.com
Borland discussion newsgroups
 
Archives   FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Review Code
Goto page 1, 2  Next
 
Post new topic   Reply to topic    BorlandTalk.com Forum Index -> Delphi OO design
View previous topic :: View next topic  
Author Message
CheGueVerra
Guest





PostPosted: Wed Aug 02, 2006 8:16 pm    Post subject: Review Code Reply with quote



Hi All,

I have been lurking here for a couple of years, always trying to improve my
knowledge and technics.
So I started a little project at home, so I could pratice some of the
technics proposed here and there on the NG.

I have posted the source rar format in attachment, I used Delphi7.

If some could look at it and tell me what they think it would be greatly
appriciated, this is for personnal knowledge, not commercial at all. If you
like the game, keep it and have fun.

CheGueVerra
Back to top
Joanna Carter [TeamB]
Guest





PostPosted: Thu Aug 03, 2006 2:00 pm    Post subject: Re: Review Code Reply with quote



"CheGueVerra" <chegueverra (AT) hotmail (DOT) com> a écrit dans le message de news:
44d0c177 (AT) newsgroups (DOT) borland.com...

| I have posted the source rar format in attachment, I used Delphi7.

If you want the best results from an attachment, please use zip format; I
for one don't have anything that can deal with rar files.

Joanna

--
Joanna Carter [TeamB]
Consultant Software Engineer
Back to top
Leif Eirik Olsen
Guest





PostPosted: Thu Aug 03, 2006 4:05 pm    Post subject: Re: Review Code Reply with quote



"Joanna Carter [TeamB]" <joanna (AT) not (DOT) for.spam> skrev i melding
news:44d1bb1e$1 (AT) newsgroups (DOT) borland.com...
Quote:
"CheGueVerra" <chegueverra (AT) hotmail (DOT) com> a écrit dans le message de news:
44d0c177 (AT) newsgroups (DOT) borland.com...

If you want the best results from an attachment, please use zip format; I
for one don't have anything that can deal with rar files.

Me neither.

.... and 'rar' in Nowegian = odd, strange or funny ..... mabe thats why :)

regards,
Leo
Back to top
Peter Morris [Droopy eyes
Guest





PostPosted: Thu Aug 03, 2006 4:30 pm    Post subject: Re: Review Code Reply with quote

You should both download 7zip, it's free and much better than WinZip. It
handles many file formats including 7z which is like ZIP but with better
compression.

Just a tip Smile
Back to top
Joanna Carter [TeamB]
Guest





PostPosted: Thu Aug 03, 2006 5:09 pm    Post subject: Re: Review Code Reply with quote

"Peter Morris [Droopy eyes software]" <pete (AT) NO_droopyeyes_SPAM (DOT) com> a écrit
dans le message de news: 44d1de4d$1 (AT) newsgroups (DOT) borland.com...

| You should both download 7zip, it's free and much better than WinZip. It
| handles many file formats including 7z which is like ZIP but with better
| compression.

I don't even use Winzip, as XP supports zip files on its own.

Joanna

--
Joanna Carter [TeamB]
Consultant Software Engineer
Back to top
Peter Morris [Droopy eyes
Guest





PostPosted: Thu Aug 03, 2006 7:58 pm    Post subject: Re: Review Code Reply with quote

Quote:
I don't even use Winzip, as XP supports zip files on its own.

But it's awful! It's about 10 times slower than using 7z. I extract files
from a zip with XP and can wait 5 seconds, I use 7z and I don't seem to wait
even 1 second.
Back to top
CheGueVerra
Guest





PostPosted: Thu Aug 03, 2006 8:13 pm    Post subject: Re: Review Code Reply with quote

Ask and you shall receive.

Thanks again for taking the time to look at this.

CheGueVerra
Back to top
Joanna Carter [TeamB]
Guest





PostPosted: Thu Aug 03, 2006 8:42 pm    Post subject: Re: Review Code Reply with quote

"Peter Morris [Droopy eyes software]" <pete (AT) NO_droopyeyes_SPAM (DOT) com> a écrit
dans le message de news: 44d20f26$1 (AT) newsgroups (DOT) borland.com...

| But it's awful! It's about 10 times slower than using 7z. I extract
files
| from a zip with XP and can wait 5 seconds, I use 7z and I don't seem to
wait
| even 1 second.

I really am not going to lose sleep over waiting a couple of seconds to
unzip a file. It gives me a chance to make that cup of tea that today's
modern compiler deprive me of :-)

Joanna

--
Joanna Carter [TeamB]
Consultant Software Engineer
Back to top
CheGueVerra
Guest





PostPosted: Thu Aug 03, 2006 10:39 pm    Post subject: Re: Review Code Reply with quote

Quote:
I really am not going to lose sleep over waiting a couple of seconds to
unzip a file. It gives me a chance to make that cup of tea that today's
modern compiler deprive me of Smile

Isn't that why there's Build all ????

CheGueVerra
Back to top
Jim Cooper
Guest





PostPosted: Fri Aug 04, 2006 2:08 am    Post subject: Re: Review Code Reply with quote

Quote:
I really am not going to lose sleep over waiting a couple of seconds to
unzip a file.

It's zipping that's slow. Anything significant in the way of directory structure
slows it to an absolute crawl


Cheers,
Jim Cooper

_____________________________________________

Jim Cooper jcooper (AT) tabdee (DOT) ltd.uk
Skype : jim.cooper
Tabdee Ltd http://www.tabdee.ltd.uk

TurboSync - Connecting Delphi to your Palm
_____________________________________________
Back to top
Jim Cooper
Guest





PostPosted: Fri Aug 04, 2006 2:08 am    Post subject: Re: Review Code Reply with quote

Quote:
Ask and you shall receive.

Can I have a million pounds? :-)


Cheers,
Jim Cooper

_____________________________________________

Jim Cooper jcooper (AT) tabdee (DOT) ltd.uk
Skype : jim.cooper
Tabdee Ltd http://www.tabdee.ltd.uk

TurboSync - Connecting Delphi to your Palm
_____________________________________________
Back to top
Charles McAllister
Guest





PostPosted: Fri Aug 04, 2006 2:22 am    Post subject: Re: Review Code Reply with quote

Jim Cooper wrote:
Quote:

Ask and you shall receive.

Can I have a million pounds? :-)

he didn't say what you'd receive. better watch out, you might receive a kick in the pants. Smile
Back to top
Jim Cooper
Guest





PostPosted: Fri Aug 04, 2006 3:13 am    Post subject: Re: Review Code Reply with quote

Quote:
he didn't say what you'd receive.

Still worth asking :-)

Quote:
better watch out, you might receive a
kick in the pants. Smile

He can try, if he's tough enough :-)


Cheers,
Jim Cooper

_____________________________________________

Jim Cooper jcooper (AT) tabdee (DOT) ltd.uk
Skype : jim.cooper
Tabdee Ltd http://www.tabdee.ltd.uk

TurboSync - Connecting Delphi to your Palm
_____________________________________________
Back to top
Joanna Carter [TeamB]
Guest





PostPosted: Fri Aug 04, 2006 8:13 am    Post subject: Re: Review Code Reply with quote

"CheGueVerra" <chegueverra (AT) hotmail (DOT) com> a écrit dans le message de news:
44d0c177 (AT) newsgroups (DOT) borland.com...

| I have been lurking here for a couple of years, always trying to improve
my
| knowledge and technics.
| So I started a little project at home, so I could pratice some of the
| technics proposed here and there on the NG.
|
| I have posted the source rar format in attachment, I used Delphi7.
|
| If some could look at it and tell me what they think it would be greatly
| appriciated, this is for personnal knowledge, not commercial at all. If
you
| like the game, keep it and have fun.

At a quick glance, my opinion is that you are not yet allocating
responsibility correctly. Some of the "management" state fields really
belong outside the dice and hand classes; you may need classes other than
the "noun" classes, whose job it is to keep track of game state.

But, nonetheless, you have made an interesting first attempt.

Joanna

--
Joanna Carter [TeamB]
Consultant Software Engineer
Back to top
Peter Morris [Droopy eyes
Guest





PostPosted: Fri Aug 04, 2006 5:04 pm    Post subject: Re: Review Code Reply with quote

Quote:
It's zipping that's slow. Anything significant in the way of directory
structure slows it to an absolute crawl

Things done often should be done efficiently. I've never heard of anyone on
their death bed saying "I wish I'd spent more time waiting for my files to
Zip" Smile
Back to top
Display posts from previous:   
Post new topic   Reply to topic    BorlandTalk.com Forum Index -> Delphi OO design All times are GMT
Goto page 1, 2  Next
Page 1 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2006 phpBB Group
SEO toolkit © 2004-2006 webmedic.